swamirishi commented on code in PR #8546:
URL: https://github.com/apache/ozone/pull/8546#discussion_r2134348302
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -165,208 +222,274 @@ public void setRatisByteLimit(int ratisByteLimit) {
@Override
public BackgroundTaskQueue getTasks() {
BackgroundTaskQueue queue = new BackgroundTaskQueue();
- if (taskCount.get() > 0) {
- LOG.info("{} Directory deleting task(s) already in progress.",
- taskCount.get());
- return queue;
- }
- try {
- deletedDirSupplier.reInitItr();
- } catch (IOException ex) {
- LOG.error("Unable to get the iterator.", ex);
- return queue;
- }
- taskCount.set(dirDeletingCorePoolSize);
- for (int i = 0; i < dirDeletingCorePoolSize; i++) {
- queue.add(new DirectoryDeletingService.DirDeletingTask(this));
+ queue.add(new DirDeletingTask(this, null));
+ if (deepCleanSnapshots) {
+ Iterator<UUID> iterator = null;
+ try {
+ iterator = snapshotChainManager.iterator(true);
+ } catch (IOException e) {
+ LOG.error("Error while initializing snapshot chain iterator.");
Review Comment:
done
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyDeletingService.java:
##########
@@ -323,8 +323,8 @@ public BackgroundTaskResult call() {
SnapshotUtils.getSnapshotInfo(getOzoneManager(),
snapshotChainManager, snapshotId);
if (snapInfo != null) {
if (snapInfo.isDeepCleaned()) {
- LOG.info("Snapshot {} has already been deep cleaned. Skipping
the snapshot in this iteration.",
- snapInfo.getSnapshotId());
+ LOG.info("Snapshot {} has already been deep cleaned. Skipping
the snapshot in this iteration. " +
+ "Snapshot name : {}", snapInfo.getSnapshotId(),
snapInfo.getName());
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
