SaketaChalamchala commented on code in PR #8436: URL: https://github.com/apache/ozone/pull/8436#discussion_r2130220831
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java: ########## @@ -71,10 +71,13 @@ public class OMMetrics implements OmMetadataReaderMetrics { private @Metric MutableCounterLong numSnapshotCreates; private @Metric MutableCounterLong numSnapshotDeletes; private @Metric MutableCounterLong numSnapshotLists; + private @Metric MutableCounterLong numSnapshotRenames; private @Metric MutableCounterLong numSnapshotDiffJobs; private @Metric MutableCounterLong numSnapshotInfos; private @Metric MutableCounterLong numSnapshotPurges; private @Metric MutableCounterLong numSnapshotSetProperties; + private @Metric MutableCounterLong numCancelSnapshotDiffs; + private @Metric MutableCounterLong numListSnapshotDiffJobs; Review Comment: Thanks for the patch @jojochuang. Can you also add metrics to track [OMSnapshotMoveTableKeysRequest.java](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotMoveTableKeysRequest.java) and [OMSnapshotMoveDeletedKeysRequest.java](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotMoveDeletedKeysRequest.java)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org