ChenSammi commented on code in PR #8492:
URL: https://github.com/apache/ozone/pull/8492#discussion_r2115169654
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -130,6 +134,10 @@ public HddsDispatcher(ConfigurationSource config,
ContainerSet contSet,
this.tokenVerifier = tokenVerifier != null ? tokenVerifier
: new NoopTokenVerifier();
this.slowOpThresholdNs = getSlowOpThresholdMs(conf) * 1000000;
+ fullVolumeLastHeartbeatTriggerMs = new AtomicLong(-1);
+ long heartbeatInterval =
+ config.getTimeDuration("hdds.heartbeat.interval", 30000,
TimeUnit.MILLISECONDS);
Review Comment:
1m doesn't matter, because you always send out the first heartbeat
immediately. This 1m is used to control the throttling, right?
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -130,6 +134,10 @@ public HddsDispatcher(ConfigurationSource config,
ContainerSet contSet,
this.tokenVerifier = tokenVerifier != null ? tokenVerifier
: new NoopTokenVerifier();
this.slowOpThresholdNs = getSlowOpThresholdMs(conf) * 1000000;
+ fullVolumeLastHeartbeatTriggerMs = new AtomicLong(-1);
+ long heartbeatInterval =
+ config.getTimeDuration("hdds.heartbeat.interval", 30000,
TimeUnit.MILLISECONDS);
Review Comment:
1m or 3s doesn't matter, because you always send out the first heartbeat
immediately. This 1m is used to control the throttling, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
