yuxian0908 commented on PR #8503: URL: https://github.com/apache/ozone/pull/8503#issuecomment-2908442257
> @yuxian0908 Thanks for the patch. Overall looks good. > > Could you add a simple test to serialize using Jackson and then deserialize using the `fromPersistedFormatImpl`? Thanks for the suggestion, @ivandika3! I’ve added a compatibility test that verifies a SnapshotDiffJob serialized with OldSnapshotDiffJobCodecForTesting (Jackson-based) can be deserialized correctly using the current protobuf-based codec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
