Jimmyweng006 commented on PR #8506: URL: https://github.com/apache/ozone/pull/8506#issuecomment-2907838994
> So two main points: > > 1. We can do a check on the ETag before the output stream is closed (i.e. key is committed) > 2. I think we can remove the deletion / abort logic for now. We can let the user decide what to do for multipart upload parts (abort it or reupload the parts). If we want to have some cleanup logic, we probably need to expose a new client protocol to clean up open keys, but this can be done in a separate ticket. > > Also as suggested by @peterxcli , we can integration tests and even acceptance tests to test the behaviors. > > @Jimmyweng006 @peterxcli Let me know your thoughts. Thanks for @ivandika3 pointing out the risk of abort committed key. I will change to below behaviors for both put/completeMultipartUpload 1. make the isETagMismatch check before committing key 2. remove cleanup when isETagMismatch check is true Regarding the integration tests(AbstractS3SDKV1Tests/AbstractS3SDKV2Tests) & acceptance tests(robot test) I will add it as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
