adoroszlai opened a new pull request, #8493: URL: https://github.com/apache/ozone/pull/8493
## What changes were proposed in this pull request? Fix the problem that `@PreDestroy` is not called on `OzoneClientCache` instance. - Use `@Singleton` instead of `@ApplicationScoped` - Avoid static state - Improve encapsulation (remove `setConfiguration` exposed for testing, use constructor injection instead) - Create separate client for S3 secret endpoint, which does not have `S3Auth` https://issues.apache.org/jira/browse/HDDS-11539 ## How was this patch tested? Existing tests. Added debug log. ``` $ docker compose logs s3g | grep OzoneClientCache s3g-1 | 2025-05-20 19:02:16,079 [qtp1658980982-156] DEBUG s3.OzoneClientCache: org.apache.hadoop.ozone.s3.OzoneClientCache@5b3f64: Created s3g-1 | 2025-05-20 19:02:16,298 [qtp1658980982-156] DEBUG s3.OzoneClientCache: org.apache.hadoop.ozone.s3.OzoneClientCache@5b3f64: Initialized s3g-1 | 2025-05-20 19:03:14,746 [shutdown-hook-0] DEBUG s3.OzoneClientCache: org.apache.hadoop.ozone.s3.OzoneClientCache@5b3f64: Closing cached client ``` CI: https://github.com/adoroszlai/ozone/actions/runs/15144265837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
