ivandika3 commented on code in PR #8366: URL: https://github.com/apache/ozone/pull/8366#discussion_r2098093370
########## hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/UnsignedChunksInputStream.java: ########## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.s3; + +import static org.apache.hadoop.ozone.s3.util.S3Utils.eol; + +import java.io.IOException; +import java.io.InputStream; +import java.util.Objects; + +/** + * Input stream implementation to read body of an unsigned chunked upload. + * <p> + * Currently, the only valid value of x-amz-content-sha256 header to indicate + * transfer unsigned payload in multiple chunks is STREAMING-UNSIGNED-PAYLOAD-TRAILER. + * Therefore, the input stream should work with chunked payloads with checksum trailer. + * Nevertheless, this input stream also supports chunked upload without trailer. Review Comment: > So this would just skip the checksum trailer check? Yes, currently since trailer checksum validation is not implemented yet, there is no use to read the trailer checksum. If we implement the trailer checksum verification, we need to update the implementation. What I meant is that currently the only unsigned chunk algorithm is `STREAMING-UNSIGNED-PAYLOAD-TRAILER` which comes with trailer, if in the future there is an unsigned chunk algorithm without trailer (e.g. `STREAMING-UNSIGNED-PAYLOAD`), then this input stream would be to handle it as well. > Does SignedChunkInputStream skip too? Yes, both implementations will not read the trailer (i.e. will stop reading after the final zero-byte chunk). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
