ChenSammi commented on code in PR #8475:
URL: https://github.com/apache/ozone/pull/8475#discussion_r2095508432
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/conf/OzoneConfiguration.java:
##########
@@ -242,10 +209,25 @@ public boolean equals(Object obj) {
}
}
+ /** Add default resources. */
public static void activate() {
- // adds the default resources
- Configuration.addDefaultResource("hdfs-default.xml");
- Configuration.addDefaultResource("hdfs-site.xml");
+ // core-default and core-site are added by parent class
+ addDefaultResource("hdfs-default.xml");
+ addDefaultResource("hdfs-site.xml");
+
+ // One generated file per module
+ addDefaultResource("hdds-common-default.xml");
Review Comment:
Can we extra the module name into an array or list, and append the
"default.xml" automatically for each module, can let a comment telling about if
there is any new module added in future, and the new module uses this
annotation based property definition mechanism, module name should be added
into this array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
