aryangupta1998 commented on code in PR #8391:
URL: https://github.com/apache/ozone/pull/8391#discussion_r2095197424
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -84,6 +84,7 @@ public class DirectoryDeletingService extends
AbstractKeyDeletingService {
private final DeletedDirSupplier deletedDirSupplier;
private AtomicInteger taskCount = new AtomicInteger(0);
+ private String dirDeletingServiceInterval;
Review Comment:
Yes, I believe it's safe to remove the test right now, as it was just
checking the value of OZONE_DIR_DELETING_SERVICE_INTERVAL, not tracing the
actual restart of the directory deleting service.
I'm not sure, but if possible, it would be better to write a test that
checks the calling of "addReconfigurationCompleteCallback()" and
"updateAndRestart()" upon changing the directory deletion interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
