swamirishi commented on code in PR #8450: URL: https://github.com/apache/ozone/pull/8450#discussion_r2094500494
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManager.java: ########## @@ -123,7 +123,25 @@ ListKeysResult listKeys(String volumeName, String bucketName, String startKey, * and a hashmap for key-value pair to be updated in the deletedTable. * @throws IOException */ - PendingKeysDeletion getPendingDeletionKeys(int count) throws IOException; + PendingKeysDeletion getPendingDeletionKeys( + CheckedFunction<Table.KeyValue<String, OmKeyInfo>, Boolean, IOException> filter, int count) + throws IOException; + + /** + * Returns a PendingKeysDeletion. It has a list of pending deletion key info + * that ups to the given count.Each entry is a {@link BlockGroup}, which + * contains the info about the key name and all its associated block IDs. + * Second is a Mapping of Key-Value pair which is updated in the deletedTable. + * + * @param count max number of keys to return. + * @return a Pair of list of {@link BlockGroup} representing keys and blocks, + * and a hashmap for key-value pair to be updated in the deletedTable. Review Comment: Volume, Bucket would be used for getting a PendingKeysDeleted for a Snapshot's KeyManager -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org