jojochuang commented on code in PR #8463:
URL: https://github.com/apache/ozone/pull/8463#discussion_r2093582107
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/service/TestKeyDeletingService.java:
##########
@@ -634,6 +644,37 @@ void cleanup() {
}
}
+ @Test
Review Comment:
consider making the test more descriptive with
```suggestion
@Test
@DisplayName("Should not update keys when purge request times out during
key deletion")
```
Or describe in javadoc.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/AbstractKeyDeletingService.java:
##########
@@ -180,24 +184,20 @@ private int
submitPurgeKeysRequest(List<DeleteBlockGroupResult> results,
expectedPreviousSnapshotNullableUUID.setUuid(HddsUtils.toProtobuf(expectedPreviousSnapshotId));
}
purgeKeysRequest.setExpectedPreviousSnapshotID(expectedPreviousSnapshotNullableUUID.build());
-
- // Add keys to PurgeKeysRequest bucket wise.
- for (Map.Entry<Pair<String, String>, List<String>> entry :
- purgeKeysMapPerBucket.entrySet()) {
- Pair<String, String> volumeBucketPair = entry.getKey();
- DeletedKeys deletedKeysInBucket = DeletedKeys.newBuilder()
- .setVolumeName(volumeBucketPair.getLeft())
- .setBucketName(volumeBucketPair.getRight())
- .addAllKeys(entry.getValue())
- .build();
- purgeKeysRequest.addDeletedKeys(deletedKeysInBucket);
- }
+ DeletedKeys deletedKeys = DeletedKeys.newBuilder()
+ .setVolumeName("")
+ .setBucketName("")
Review Comment:
we can't simply ignore values for these two fields because they are
required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
