[ 
https://issues.apache.org/jira/browse/HDDS-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952175#comment-17952175
 ] 

Ethan Rose commented on HDDS-13037:
-----------------------------------

We should add replication options. We can create a picocli mixin from the 
[ReplicationOptions|https://github.com/apache/ozone/blob/e93d791e7fa6124d39f17136a2ea1d714af6ed2f/hadoop-ozone/cli-shell/src/main/java/org/apache/hadoop/ozone/shell/ReplicationOptions.java#L34]
 to add this.

> Either hide container create command or add replication options
> ---------------------------------------------------------------
>
>                 Key: HDDS-13037
>                 URL: https://issues.apache.org/jira/browse/HDDS-13037
>             Project: Apache Ozone
>          Issue Type: Improvement
>          Components: Ozone CLI
>    Affects Versions: 1.4.0, 2.0.0, 1.4.1
>            Reporter: Soumitra Sulav
>            Priority: Major
>
> Current, container create command create a container with Replication factor 
> as ONE and Replication Type as STANDALONE which might be relevant for 
> debugging or unit tests but doesn't have a real requirement in creating 
> actual containers which have Replication Types as EC/RATIS with configuration 
> replication factor/algo.
> The command doesn't expose such options.
> {code:java}
> bash-5.1$ ozone admin container create -h
> Usage: ozone admin container create [-hV] [--verbose] [-id=<scmServiceId>]
>                                     [-o=<owner>] [--scm=<scm>]
> Create container
>   -h, --help            Show this help message and exit.
>       -id, --service-id=<scmServiceId>
>                         ServiceId of SCM HA Cluster
>   -o, --owner=<owner>   Owner of the new container
>       --scm=<scm>       The destination scm (host:port)
>   -V, --version         Print version information and exit.
>       --verbose         More verbose output. Show the stack trace of the 
> errors.
> bash-5.1$ ozone admin container create
> Container 3011 is created.
> bash-5.1$ ozone admin container info 3011
> Container id: 3011
> Pipeline id: ac7ac832-0041-4423-bc8e-afee16302928
> Write PipelineId: ac7ac832-0041-4423-bc8e-afee16302928
> Write Pipeline State: OPEN
> Container State: OPEN
> Datanodes: 
> [d20d5ffb-d302-49c8-8093-f0ff52b09650/ccycloud-2.quasar-tcgogy.root.comops.site]
> Replicas: [State: OPEN; ReplicaIndex: 0; Origin: 
> d20d5ffb-d302-49c8-8093-f0ff52b09650; Location: 
> d20d5ffb-d302-49c8-8093-f0ff52b09650/ozone-ha-datanode-2]
> bash-5.1$ ozone admin container info 3011 --json | jq -r 
> ".containerInfo.replicationConfig"
> {
>   "replicationFactor": "ONE",
>   "requiredNodes": 1,
>   "replicationType": "STANDALONE"
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to