ChenSammi commented on code in PR #8383: URL: https://github.com/apache/ozone/pull/8383#discussion_r2084416144
########## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java: ########## @@ -46,9 +45,6 @@ public final class OzoneAclUtil { static final Logger LOG = LoggerFactory.getLogger(OzoneAclUtil.class); - private static ACLType[] userRights; Review Comment: I would prefer keep these two global variables, to avoid creating the short lived collections object and array during each create key request. Others look good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org