errose28 commented on code in PR #8402:
URL: https://github.com/apache/ozone/pull/8402#discussion_r2080071939
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/checksum/ContainerMerkleTreeWriter.java:
##########
@@ -49,21 +49,67 @@ public class ContainerMerkleTreeWriter {
public static final Supplier<ChecksumByteBuffer> CHECKSUM_BUFFER_SUPPLIER =
ChecksumByteBufferFactory::crc32CImpl;
/**
- * Constructs an empty Container merkle tree object.
+ * Constructs a writer for an initially empty container merkle tree.
*/
public ContainerMerkleTreeWriter() {
id2Block = new TreeMap<>();
}
+ /**
+ * Constructs a writer for a container merkle tree which initially contains
all the information from the specified
+ * proto.
+ */
+ public ContainerMerkleTreeWriter(ContainerProtos.ContainerMerkleTree
fromTree) {
+ id2Block = new TreeMap<>();
+ for (ContainerProtos.BlockMerkleTree blockTree:
fromTree.getBlockMerkleTreeList()) {
+ long blockID = blockTree.getBlockID();
+ addBlock(blockID);
Review Comment:
Yes, helper method has been fixed in the follow-up commit. Let me add a unit
test for converting from proto to tree writer in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
