Re: [PR] HDDS-12810. Check and reserve space atomically in VolumeChoosingPolicy [ozone]

[via GitHub]

ChenSammi commented on PR #8360:
URL: https://github.com/apache/ozone/pull/8360#issuecomment-2862654840

   > I updated the data. Interesting thing is this time roundrobin-sync is 
better than roundrobin.
   > 
   > ![Screenshot 2025-05-08 at 16 59 
04](https://private-user-images.githubusercontent.com/19790142/441627953-2b498906-b47d-4e31-a25f-d5bddb0b2ae2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDY3MDE2NjYsIm5iZiI6MTc0NjcwMTM2NiwicGF0aCI6Ii8xOTc5MDE0Mi80NDE2Mjc5NTMtMmI0OTg5MDYtYjQ3ZC00ZTMxLWEyNWYtZDViZGRiMGIyYWUyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTA4VDEwNDkyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc4NzYwMWUzYjk1NDdlYWQxYTExODJlODFkODkwZWVlNTZkYTVmODM3MjFjYThkMThkMzI2MTBhZGY0MTFiOWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.SbikgjUyI6WetsPb-POey-yJn7Ox83WF5X2gy9taTFU)
   
   It looks like this statement " nextVolumeIndex.compareAndSet(nextIndex, 
currentVolumeIndex);" in RoundRobinVolumeChoosingPolicy is the reason why 
synchronized has better performance for RoundRobinVolumeChoosingPolicy.  Once 
nextVolumeIndex.compareAndSet is replaced with nextVolumeIndex.set, 
synchronized will have the similar performance as without synchronized. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org