jojochuang commented on code in PR #8141: URL: https://github.com/apache/ozone/pull/8141#discussion_r2078657515
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java: ########## @@ -220,6 +241,8 @@ void cleanup() { LOG.debug("Closing SnapshotId {}. It is not being referenced anymore.", k); // Close the instance, which also closes its DB handle. try { + compactSnapshotDB(v.get()); Review Comment: According to https://github.com/facebook/rocksdb/issues/3335 RocksDatabase.compact() is synchronous so it doesn't need to wait? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org