sodonnel commented on code in PR #8408:
URL: https://github.com/apache/ozone/pull/8408#discussion_r2077270638
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamProxy.java:
##########
@@ -117,6 +117,8 @@ private synchronized void setReaderType() {
int expected = expectedDataLocations(repConfig, getLength());
int available = availableDataLocations(blockInfo.getPipeline(), expected);
reconstructionReader = available < expected;
+ LOG.info("Available data locations: {}, Expected data locations: {}. Based
on this online reconstruction is: {}",
+ available, expected, reconstructionReader ? "triggered." : "not
triggered.");
Review Comment:
There is also a method `failoverToReconstructionRead` where the read can
start off a normal and them move to a reconstruction one if it encounters an
error reading one of the replicas. However we do seem to log that already:
```
if (e instanceof BadDataLocationException) {
String message = "Failing over to reconstruction read due" +
" to an error in ECBlockReader.";
if (LOG.isDebugEnabled()) {
LOG.debug(message, e);
} else {
LOG.warn("{} Exception Class: {} , Exception Message: {}",
message, e.getClass().getName(), e.getMessage());
}
failoverToReconstructionRead(
((BadDataLocationException) e).getFailedLocations(),
lastPosition);
```
However the other problem is - where does this log go? It goes into the
client log, which is suppressed / disabled for CLI commands, and it will go
into the process log. There will not be a centralized location where these logs
can be queried etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
