adoroszlai commented on code in PR #8249:
URL: https://github.com/apache/ozone/pull/8249#discussion_r2071087119
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsConfigKeys.java:
##########
@@ -28,15 +28,15 @@ public final class HddsConfigKeys {
public static final String HDDS_HEARTBEAT_INTERVAL_DEFAULT =
"30s";
public static final String HDDS_INITIAL_HEARTBEAT_INTERVAL =
- "hdds.initial.heartbeat.interval";
+ "hdds.heartbeat.initial-interval";
Review Comment:
> How about rename also the variables?
>
> * HDDS_INITIAL_HEARTBEAT_INTERVAL -> HDDS_HEARTBEAT_INITIAL_INTERVAL
>
> and all the other variables.
I'd rather not, I think it inflates the patch unnecessarily. One of the
benefits of the indirection (vs. using the value directly everywhere) is that
it allows changing the value in a single place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
