xichen01 commented on code in PR #8275: URL: https://github.com/apache/ozone/pull/8275#discussion_r2058889336
########## hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/helpers/TestOmLCExpiration.java: ########## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.helpers; + +import static org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes.INVALID_REQUEST; +import static org.apache.hadoop.ozone.om.helpers.OMLCUtils.assertOMException; +import static org.apache.hadoop.ozone.om.helpers.OMLCUtils.getFutureDateString; +import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; + +import org.junit.jupiter.api.Test; + +/** + * Test OmLCExpiration. + */ +class TestOmLCExpiration { + + @Test + public void testCreateValidOmLCExpiration() { + OmLCExpiration.Builder exp1 = new OmLCExpiration.Builder() + .setDays(30); + assertDoesNotThrow(exp1::build); + + OmLCExpiration.Builder exp2 = new OmLCExpiration.Builder() + .setDate("2099-10-10T00:00:00Z"); + assertDoesNotThrow(exp2::build); + + OmLCExpiration.Builder exp3 = new OmLCExpiration.Builder() + .setDays(1); + assertDoesNotThrow(exp3::build); + + OmLCExpiration.Builder exp4 = new OmLCExpiration.Builder() + .setDate("2099-12-31T00:00:00Z"); + assertDoesNotThrow(exp4::build); + + OmLCExpiration.Builder exp5 = new OmLCExpiration.Builder() + .setDate("2099-02-15T00:00:00.000Z"); + assertDoesNotThrow(exp5::build); + } + + @Test + public void testCreateInValidOmLCExpiration() { + OmLCExpiration.Builder exp1 = new OmLCExpiration.Builder() + .setDays(30) + .setDate(getFutureDateString(100)); + assertOMException(exp1::build, INVALID_REQUEST, + "Either 'days' or 'date' should be specified, but not both or neither."); + + OmLCExpiration.Builder exp2 = new OmLCExpiration.Builder() + .setDays(-1); + assertOMException(exp2::build, INVALID_REQUEST, + "'Days' for Expiration action must be a positive integer"); + + OmLCExpiration.Builder exp3 = new OmLCExpiration.Builder() + .setDate(null); + assertOMException(exp3::build, INVALID_REQUEST, + "Either 'days' or 'date' should be specified, but not both or neither."); + + OmLCExpiration.Builder exp4 = new OmLCExpiration.Builder() + .setDate(""); + assertOMException(exp4::build, INVALID_REQUEST, + "Either 'days' or 'date' should be specified, but not both or neither."); + + OmLCExpiration.Builder exp5 = new OmLCExpiration.Builder(); + assertOMException(exp5::build, INVALID_REQUEST, + "Either 'days' or 'date' should be specified, but not both or neither."); + + OmLCExpiration.Builder exp6 = new OmLCExpiration.Builder() + .setDate("10-10-2099"); + assertOMException(exp6::build, INVALID_REQUEST, + "'Date' must be in ISO 8601 format"); + + OmLCExpiration.Builder exp7 = new OmLCExpiration.Builder() + .setDate("2099-12-31T00:00:00"); + assertOMException(exp7::build, INVALID_REQUEST, + "'Date' must be in ISO 8601 format"); + + // Testing for date in the past + OmLCExpiration.Builder exp8 = new OmLCExpiration.Builder() + .setDate(getFutureDateString(-1)); + assertOMException(exp8::build, INVALID_REQUEST, + "'Date' must be in the future"); + + OmLCExpiration.Builder exp9 = new OmLCExpiration.Builder() + .setDays(0); + assertOMException(exp9::build, INVALID_REQUEST, + "Either 'days' or 'date' should be specified, but not both or neither."); + + // 1 minute ago + OmLCExpiration.Builder exp10 = new OmLCExpiration.Builder() + .setDate(getFutureDateString(0, 0, -1)); + assertOMException(exp10::build, INVALID_REQUEST, + "'Date' must be in the future"); + } + + @Test + public void testDateMustBeAtMidnightUTC() { + // Acceptable date - midnight UTC + OmLCExpiration.Builder validExp = new OmLCExpiration.Builder() + .setDate("2099-10-10T00:00:00Z"); + assertDoesNotThrow(validExp::build); + + // Non-midnight UTC dates should be rejected + OmLCExpiration.Builder exp1 = new OmLCExpiration.Builder() + .setDate("2099-10-10T10:00:00Z"); + assertOMException(exp1::build, INVALID_REQUEST, "'Date' must be at midnight GMT"); + + OmLCExpiration.Builder exp2 = new OmLCExpiration.Builder() + .setDate("2099-10-10T00:30:00Z"); + assertOMException(exp2::build, INVALID_REQUEST, "'Date' must be at midnight GMT"); + + OmLCExpiration.Builder exp3 = new OmLCExpiration.Builder() + .setDate("2099-10-10T00:00:30Z"); + assertOMException(exp3::build, INVALID_REQUEST, "'Date' must be at midnight GMT"); + + OmLCExpiration.Builder exp4 = new OmLCExpiration.Builder() + .setDate("2099-10-10T00:00:00.123Z"); + assertOMException(exp4::build, INVALID_REQUEST, "'Date' must be at midnight GMT"); + + // Non-UTC timezone should be rejected + OmLCExpiration.Builder exp5 = new OmLCExpiration.Builder() + .setDate("2099-10-10T00:00:00+01:00"); + assertOMException(exp5::build, INVALID_REQUEST, "'Date' must be at midnight GMT"); + + OmLCExpiration.Builder exp8 = new OmLCExpiration.Builder() + .setDate("2099-10-10T00:00:00"); Review Comment: Yes, this is a way to omit the time zone. In fact, AWS's LifecycleConfig allows this, and it will default the time to UTC. But our requirement is that the time and time zone must be clear (Examples: 2042-04-02T00:00:00Z' or '2042-04-02T00:00:00+00:00.), otherwise it will be ambiguous, because omitting the time zone will be considered as local Time, but local is not a clear definition. Refer to https://en.wikipedia.org/wiki/ISO_8601#Local_time_(unqualified), It is clearly stated here that it is recommended to provide time zone information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
