hemantk-12 commented on code in PR #8214: URL: https://github.com/apache/ozone/pull/8214#discussion_r2056783437
########## hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java: ########## @@ -1140,7 +1193,17 @@ private void addFileInfoToCompactionLogTable( builder.setCompactionReason(compactionReason); } - addToCompactionLogTable(builder.build()); + CompactionLogEntry compactionLogEntry = builder.build(); + byte[] key = addToCompactionLogTable(compactionLogEntry); + // Add the compaction log entry to the prune queue so that the backup input sst files can be pruned. + if (isNativeLibsLoaded) { + try { + pruneQueue.put(Pair.of(key, compactionLogEntry)); + } catch (InterruptedException e) { + LOG.error("Could not add backup SST files in queue to be pruned. {}", + compactionLogEntry.getInputFileInfoList(), e); + } + } Review Comment: No. `onCompactionComplete` mainly adds entries to `compactionLogTable` and `OM startup` is for backward compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org