chungen0126 commented on code in PR #8239:
URL: https://github.com/apache/ozone/pull/8239#discussion_r2055899821
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/storage/DiskBalancerConfiguration.java:
##########
@@ -146,15 +146,31 @@ public Class<?> getContainerChoosingPolicyClass() {
return containerChoosingPolicyClass;
}
+ @Config(key = "stop.after.disk.even",
+ type = ConfigType.BOOLEAN,
+ defaultValue = "true",
+ tags = {ConfigTag.DISKBALANCER},
+ description = "If true, the DiskBalancer will automatically stop once
disks are balanced.")
+ private boolean stopAfterDiskEven = true;
+
+ public boolean getStopAfterDiskEven() {
Review Comment:
Please rename this to `isStopAfterDiskEven()`.
```suggestion
public boolean isStopAfterDiskEven() {
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -352,6 +359,18 @@ public BackgroundTaskQueue getTasks() {
}
if (queue.isEmpty()) {
Review Comment:
Just curious. If `pair` is null, does it mean that the disk is even? Could
we break the loop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
