adoroszlai commented on code in PR #8293:
URL: https://github.com/apache/ozone/pull/8293#discussion_r2051385370
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -230,12 +230,11 @@ public String getNamespace() {
datanodeDetails.setRevision(
HddsVersionInfo.HDDS_VERSION_INFO.getRevision());
TracingUtil.initTracing(
- "HddsDatanodeService." + datanodeDetails.getUuidString()
- .substring(0, 8), conf);
+ "HddsDatanodeService." + datanodeDetails.getID(), conf);
LOG.info("HddsDatanodeService {}", datanodeDetails);
// Authenticate Hdds Datanode service if security is enabled
if (OzoneSecurityUtil.isSecurityEnabled(conf)) {
- component = "dn-" + datanodeDetails.getUuidString();
+ component = "dn-" + datanodeDetails;
Review Comment:
```suggestion
component = "dn-" + datanodeDetails.getID();
```
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/MockNodeManager.java:
##########
@@ -271,12 +271,11 @@ public List<DatanodeDetails> getNodes(
long used = nodeMetricMap.get(dd).getScmUsed().get();
long remaining = nodeMetricMap.get(dd).getRemaining().get();
StorageReportProto storage1 = HddsTestUtils.createStorageReport(
- di.getID(), "/data1-" + di.getUuidString(),
+ di.getID(), "/data1-" + di.getID(),
capacity, used, remaining, null);
MetadataStorageReportProto metaStorage1 =
HddsTestUtils.createMetadataStorageReport(
- "/metadata1-" + di.getUuidString(), capacity, used,
- remaining, null);
+ "/metadata1-" + di, capacity, used, remaining, null);
Review Comment:
```suggestion
"/metadata1-" + di.getID(), capacity, used, remaining, null);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
