ChenSammi commented on PR #8127: URL: https://github.com/apache/ozone/pull/8127#issuecomment-2808818760
> > So it naturally come with idea to save potential wasted IO resources, which I believe is not hard to understand > > Complexity is built up with lots of "things like this" over time. This change may be somewhat simple, but it does increase coupling in the system, as now replication supervisor is depended on by the Disk Balancer, where it otherwise would not be. > > I don't think we should make this change. The chances of this saving a tiny bit of I/O on a cluster once or twice isn't worth the additional code. I would say optimization and complexity most time come together. But this optimization is a very low hanging fruit, it doesn't require complex logic. And in a heavy workload datanode environment, I believe it can avoid things getting worse. I would prefer to keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
