sadanand48 commented on code in PR #8124:
URL: https://github.com/apache/ozone/pull/8124#discussion_r2043783922
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1980,6 +1980,8 @@ message ListSnapshotDiffJobRequest {
required string bucketName = 2;
optional string jobStatus = 3;
optional bool listAll = 4;
+ optional string prevSnapshotDiffJob = 5;
+ optional uint32 maxListResult = 6;
Review Comment:
It will always be 0 after this PR as if not passed by older client , the
default int proto is taken as 0. I know its not a very important API and used
mainly via cli but since its simple to fix it we should I believe :
https://github.com/apache/ozone/pull/8124/files#r2043763369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]