swamirishi commented on code in PR #8243:
URL: https://github.com/apache/ozone/pull/8243#discussion_r2040703929
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/metadata/BigIntegerCodec.java:
##########
@@ -27,6 +29,7 @@
public final class BigIntegerCodec implements Codec<BigInteger> {
private static final Codec<BigInteger> INSTANCE = new BigIntegerCodec();
+ private static final Comparator<BigInteger> COMPARATOR = (o1, o2) ->
Objects.compare(o1, o2, BigInteger::compareTo);
Review Comment:
To make it fool proof then we have to set the rocksdb comparator align with
Java side Comparator by implementing this and setting in the ColumnFamilyOptions
https://github.com/facebook/rocksdb/blob/0bf9079d44eea91afda7151306d3a3439a39511b/java/src/main/java/org/rocksdb/AbstractComparator.java#L16-L18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
