adoroszlai commented on code in PR #8096:
URL: https://github.com/apache/ozone/pull/8096#discussion_r2039330088
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/upgrade/UpgradeManager.java:
##########
@@ -91,7 +92,7 @@ public DatanodeStoreSchemaThreeImpl getDBStore(HddsVolume
volume) {
public static class Result {
private Map<Long, UpgradeTask.UpgradeContainerResult> resultMap;
private final HddsVolume hddsVolume;
- private final long startTimeMs = System.currentTimeMillis();
+ private final long startTimeMs = Time.monotonicNow();
private long endTimeMs = 0L;
Review Comment:
@chiacyu instead of reverting `startTimeMs` to `currentTimeMillis()`, please
update `endTimeMs` to also use `monotonicNow()`
https://github.com/apache/ozone/blob/86b75054cf84fd90795135c267eabc516dd71518/hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/upgrade/UpgradeManager.java#L95-L96
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/upgrade/UpgradeTask.java:
##########
@@ -383,7 +384,7 @@ public static class UpgradeContainerResult {
private final ContainerData originContainerData;
private ContainerData newContainerData;
private long totalRow = 0L;
- private final long startTimeMs = System.currentTimeMillis();
+ private final long startTimeMs = Time.monotonicNow();
private long endTimeMs = 0L;
Review Comment:
same here
https://github.com/apache/ozone/blob/86b75054cf84fd90795135c267eabc516dd71518/hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/upgrade/UpgradeTask.java#L386-L387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
