hemantk-12 commented on code in PR #8214: URL: https://github.com/apache/ozone/pull/8214#discussion_r2032007781
########## hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java: ########## @@ -1382,6 +1393,62 @@ public void pruneSstFiles() { } } + /** + * Defines the task that removes OMKeyInfo from SST files from backup directory to + * save disk space. + */ + public void pruneSstFileValues() { + if (!shouldRun()) { + return; + } + Path sstBackupDirPath = Paths.get(sstBackupDir); + String kVSeparator = ","; + + try (Stream<Path> files = Files.list(sstBackupDirPath) Review Comment: We can improve it further by maintaining a BlockingQueue, adding not-cleaned files to the queue after service startup, and after the compilation, so that it doesn't have to go over the whole compaction DAG in each run to filter cleaned files. cc: @swamirishi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org