adoroszlai commented on code in PR #8235:
URL: https://github.com/apache/ozone/pull/8235#discussion_r2030530083
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -347,6 +347,14 @@
Default is 5s.
</description>
</property>
+ <property>
+ <name>hdds.ratis.leader.first.election.minimum.timeout.duration</name>
Review Comment:
`hdds.ratis.leader.first-election.minimum.timeout.duration`
to be more like the one for SCM
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -1154,6 +1162,14 @@
if the default value for this config is not used.
</description>
</property>
+ <property>
+ <name>hdds.initial.heartbeat.interval</name>
Review Comment:
I suggest `hdds.heartbeat.interval.initial` for common prefix.
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -3834,6 +3858,13 @@
election. Default is 1s.</description>
</property>
<property>
+ <name>ozone.scm.ha.raft.server.rpc.first-election.timeout</name>
Review Comment:
`ozone.scm.ha.ratis.leader.first-election.timeout` is more in line with
existing keys like `ozone.scm.ha.ratis.leader.election.timeout`.
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -1162,6 +1178,14 @@
The heartbeat interval from a Datanode to Recon.
</description>
</property>
+ <property>
+ <name>hdds.recon.initial.heartbeat.interval</name>
Review Comment:
`hdds.recon.heartbeat.interval.initial`
(Ideally these keys for Recon should have been
`hdds.heartbeat.interval.recon` and `...recon.initial`, but
`hdds.recon.heartbeat.interval` already exists since 1.3.0, so we should rename
them with deprecation in separate task.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
