adoroszlai commented on code in PR #143: URL: https://github.com/apache/ozone-site/pull/143#discussion_r2030124813
########## docs/08-developer-guide/04-project/02-release-guide.md: ########## @@ -155,17 +189,18 @@ Once the previous two pull requests to update protolock files and the Ozone SNAP :::important The parent commit of the release branch should be the commit that was merged in the [proto.lock file update](#build-and-commit-protolock-files-to-the-master-branch). ::: -Name the branch after the major and minor version of the release, so patch releases can also be done off this branch. For example, If releasing 1.2.0, create a branch called `ozone-1.2` . All release related changes will go to this branch until the release is complete. +Name the branch after the major and minor version of the release, so patch releases can also be done off this branch. For example, If releasing 2.0.0, create a branch called `ozone-2.0` . All release related changes will go to this branch until the release is complete. ### Set Up Local Environment The following variables will be referenced in commands: ```bash -export VERSION=1.1.0 # Set to the version of ozone being released. +export VERSION=2.0.0 # Set to the version of ozone being released. export RELEASE_DIR=~/ozone-release/ # ozone-release needs to be created export CODESIGNINGKEY=<your_gpg_key_id> export RC=0 # Set to the number of the current release candidate, starting at 0. +export MAVEN_GPG_PASSPHRASE=<PASSPHRASE> # Maven passes this environment variable to gpg for passphrase. Review Comment: With `pinentry` installed, I think this is unnecessary. ########## docs/08-developer-guide/04-project/02-release-guide.md: ########## @@ -426,6 +479,10 @@ git tag -s "ozone-$VERSION" -m "Ozone $VERSION release" git push origin "ozone-$VERSION" ``` +### Update GitHub Releases page + +add the release information [GitHub Releases](https://github.com/apache/ozone/releases/new) page. See the [1.4.1 Release page](https://github.com/apache/ozone/releases/tag/ozone-1.4.1) for an example. Review Comment: `add the release information GitHub Releases page` does not seem to be a correct sentence. ########## docs/08-developer-guide/04-project/02-release-guide.md: ########## @@ -24,6 +33,25 @@ brew install gnu-tar export PATH="$HOMEBREW_PREFIX/opt/gnu-tar/libexec/gnubin:$PATH" ``` +You may encounter problems regarding sqlite3 compatibility issues when installing Subversion on Mac. Use the following workaround to resolve it: + +```bash title="Install Subversion on Mac" +# fix svn sqlite3 incompatibility +brew update +brew remove sqlite svn +brew reinstall sqlite svn --build-from-source +``` + +</TabItem> +<TabItem value="linux" label="Linux"> Review Comment: I think we should somehow indicate the specific Linux distro these `yum` commands were tested on. Various package managers exist and even package names tend to be different across them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
