adoroszlai commented on code in PR #8229:
URL: https://github.com/apache/ozone/pull/8229#discussion_r2029739089
##########
hadoop-ozone/dist/src/main/compose/upgrade/testlib.sh:
##########
@@ -106,7 +106,7 @@ run_test() {
local test_dir="$_upgrade_dir/upgrades/$upgrade_type"
local callback_dir="$test_dir"/callbacks
- local
execution_dir="$test_dir"/execution/"${OZONE_UPGRADE_FROM}-${OZONE_UPGRADE_TO}"
+ local
execution_dir="$test_dir"/execution/"$compose_cluster"/"${OZONE_UPGRADE_FROM}-${OZONE_UPGRADE_TO}"
Review Comment:
Both `$upgrade_type` and `$compose_cluster` are included in the full path,
so files are not overwritten when executing the test. However, only the name
of the leaf directory is used when moving results/outputs of each execution to
the final directory. Therefore, the artifact still does not have test results
for both executions. You can verify this by comparing the contents of the
[artifact for this
change](https://github.com/Jimmyweng006/ozone/actions/runs/14265344587/artifacts/2883270133)
vs. [one on `master`
branch](https://github.com/apache/ozone/actions/runs/14265561966/artifacts/2882997277):
they have exactly the same files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
