aryangupta1998 commented on code in PR #8095:
URL: https://github.com/apache/ozone/pull/8095#discussion_r2029554492
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineReportHandler.java:
##########
@@ -140,9 +131,7 @@ protected void processPipelineReport(PipelineReport report,
}
}
if (pipeline.isHealthy()) {
- if (pipelineAvailabilityCheck && scmSafeModeManager.getInSafeMode()) {
Review Comment:
I think we should retain the scmSafeModeManager.getInSafeMode() check and
only remove pipelineAvailabilityCheck.
Without the safemode check, SCMEvents.OPEN_PIPELINE will be fired every time
a DN sends a report to SCM—even when SCM is not in safemode. While this may not
have a functional impact (since HealthyPipelineSafeModeRule#onMessage() also
checks for safemode before acting), it leads to unnecessary event publishing
and processing.
Keeping the safemode check avoids this overhead and keeps the event flow
cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
