jojochuang commented on code in PR #7109:
URL: https://github.com/apache/ozone/pull/7109#discussion_r2023703973


##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -307,6 +307,14 @@ enum ReplicationFactor {
     ZERO = 0; // Invalid Factor
 }
 
+enum StorageType {
+    DISK_TYPE = 1;
+    SSD_TYPE = 2;
+    ARCHIVE_TYPE = 3;
+    RAM_DISK_TYPE = 4;
+    PROVIDED_TYPE = 5;

Review Comment:
   I don't recall who, but back in HDFS land after storage policy feature was 
implemented, someone (Arpit or Anu?) regrettably said it was a mistake to have 
these types continuous, because it wasn't possible to add any storage types in 
between. It might be a good idea to space them out.
   
   @szetszwo do you recall?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to