adoroszlai commented on code in PR #8212:
URL: https://github.com/apache/ozone/pull/8212#discussion_r2027578098
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -426,14 +430,17 @@ connectionFactory, getOzoneManagerSnapshotUrl(),
// RocksDB.
reconContext.updateHealthStatus(new AtomicBoolean(true));
reconContext.getErrors().remove(ReconContext.ErrorCode.GET_OM_DB_SNAPSHOT_FAILED);
+
return new RocksDBCheckpoint(untarredDbDir);
+
} catch (IOException e) {
- LOG.error("Unable to obtain Ozone Manager DB Snapshot. ", e);
+ LOG.error("Unable to obtain Ozone Manager DB Snapshot.", e);
reconContext.updateHealthStatus(new AtomicBoolean(false));
reconContext.updateErrors(ReconContext.ErrorCode.GET_OM_DB_SNAPSHOT_FAILED);
} finally {
- FileUtils.deleteQuietly(targetFile);
+ tarExtractor.shutdown();
Review Comment:
`tarExtractor` should be shut down in `stop()`, not after getting a single
DB snapshot, if you want to use it more than once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
