sumitagrawl commented on code in PR #8072: URL: https://github.com/apache/ozone/pull/8072#discussion_r2024139976
########## hadoop-ozone/tools/src/main/resources/container-log-db-queries.properties: ########## @@ -0,0 +1,24 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +CREATE_DATANODE_CONTAINER_LOG_TABLE=CREATE TABLE IF NOT EXISTS DatanodeContainerLogTable (datanode_id INTEGER NOT NULL, container_id INTEGER NOT NULL, timestamp TEXT NOT NULL, container_state TEXT NOT NULL, bcsid INTEGER NOT NULL, error_message TEXT, PRIMARY KEY (datanode_id, container_id, container_state, bcsid, error_message)); +CREATE_CONTAINER_LOG_TABLE=CREATE TABLE IF NOT EXISTS ContainerLogTable (datanode_id INTEGER NOT NULL, container_id INTEGER NOT NULL, latest_state TEXT NOT NULL, latest_bcsid INTEGER NOT NULL, PRIMARY KEY (datanode_id, container_id)); Review Comment: we can add index also here. ########## hadoop-ozone/tools/src/main/resources/container-log-db-queries.properties: ########## @@ -0,0 +1,24 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +CREATE_DATANODE_CONTAINER_LOG_TABLE=CREATE TABLE IF NOT EXISTS DatanodeContainerLogTable (datanode_id INTEGER NOT NULL, container_id INTEGER NOT NULL, timestamp TEXT NOT NULL, container_state TEXT NOT NULL, bcsid INTEGER NOT NULL, error_message TEXT, PRIMARY KEY (datanode_id, container_id, container_state, bcsid, error_message)); Review Comment: primary key does not seems to be unique. for double open case, dnid,cid, state, bcsid and error message will be same. ########## hadoop-ozone/tools/src/main/resources/container-log-db-queries.properties: ########## @@ -0,0 +1,24 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +CREATE_DATANODE_CONTAINER_LOG_TABLE=CREATE TABLE IF NOT EXISTS DatanodeContainerLogTable (datanode_id INTEGER NOT NULL, container_id INTEGER NOT NULL, timestamp TEXT NOT NULL, container_state TEXT NOT NULL, bcsid INTEGER NOT NULL, error_message TEXT, PRIMARY KEY (datanode_id, container_id, container_state, bcsid, error_message)); Review Comment: we can add other container fields also like index, log level to have complete view. usages many have null value. ########## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/containerlog/parser/DatanodeContainerInfo.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.containerlog.parser; + +/** + * Datanode container information. + */ + +public class DatanodeContainerInfo { + + private String timestamp; + private String state; + private long bcsid; + private String errorMessage; + + public DatanodeContainerInfo(String timestamp, String state, long bcsid, String errorMessage) { + this.timestamp = timestamp; + this.state = state; + this.bcsid = bcsid; + this.errorMessage = errorMessage; + } + + public DatanodeContainerInfo(String timestamp, String state, long bcsid) { + this.timestamp = timestamp; + this.state = state; + this.bcsid = bcsid; + this.errorMessage = null; + } + + public String getTimestamp() { + return timestamp; + } + + public void setTimestamp(String timestamp) { + this.timestamp = timestamp; + } + + public String getState() { + return state; + } + + public void setState(String state) { + this.state = state; + } + + public long getBcsid() { + return bcsid; + } + + public void setBcsid(long bcsid) { + this.bcsid = bcsid; + } + + public String getErrorMessage() { + return errorMessage; + } + + public void setErrorMessage(String errorMessage) { + this.errorMessage = errorMessage; + } + + @Override Review Comment: do we need output as JSON or can be same format as container log ? and if json, can use json builder, below format may not match ########## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/containerlog/parser/ContainerDatanodeDatabase.java: ########## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.containerlog.parser; + +import java.io.FileNotFoundException; +import java.io.InputStream; +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.List; +import java.util.Map; +import java.util.Properties; +import java.util.stream.Collectors; +import org.sqlite.SQLiteConfig; + +/** + * Datanode container Database. + */ + +public class ContainerDatanodeDatabase { + + private static Map<String, String> queries; + + static { + loadProperties(); + } + + private static void loadProperties() { + Properties props = new Properties(); + try (InputStream inputStream = ContainerDatanodeDatabase.class.getClassLoader() + .getResourceAsStream(DBConsts.PROPS_FILE)) { + + if (inputStream != null) { + props.load(inputStream); + queries = props.entrySet().stream() + .collect(Collectors.toMap( + e -> e.getKey().toString(), + e -> e.getValue().toString() + )); + } else { + throw new FileNotFoundException("Property file '" + DBConsts.PROPS_FILE + "' not found."); + } + } catch (Exception e) { + e.printStackTrace(); + } + } + + private static Connection getConnection() throws Exception { + Class.forName(DBConsts.DRIVER); + + SQLiteConfig config = new SQLiteConfig(); + + config.setJournalMode(SQLiteConfig.JournalMode.OFF); + config.setCacheSize(DBConsts.CACHE_SIZE); + config.setLockingMode(SQLiteConfig.LockingMode.EXCLUSIVE); + config.setSynchronous(SQLiteConfig.SynchronousMode.OFF); + config.setTempStore(SQLiteConfig.TempStore.MEMORY); + + return DriverManager.getConnection(DBConsts.CONNECTION_PREFIX + DBConsts.DATABASE_NAME, config.toProperties()); + } + + public void createDatanodeContainerLogTable() { + String createTableSQL = queries.get("CREATE_DATANODE_CONTAINER_LOG_TABLE"); + try (Connection connection = getConnection(); + Statement dropStmt = connection.createStatement(); + Statement createStmt = connection.createStatement()) { + dropTable(DBConsts.DATANODE_CONTAINER_LOG_TABLE_NAME,dropStmt); + createStmt.execute(createTableSQL); + createDatanodeContainerIndex(createStmt); + } catch (SQLException e) { + System.err.println("Error while creating the table: " + e.getMessage()); Review Comment: we need throw exception as failure to avoid continue processing. ########## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/containerlog/parser/ContainerDatanodeDatabase.java: ########## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.containerlog.parser; + +import java.io.FileNotFoundException; +import java.io.InputStream; +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.List; +import java.util.Map; +import java.util.Properties; +import java.util.stream.Collectors; +import org.sqlite.SQLiteConfig; + +/** + * Datanode container Database. + */ + +public class ContainerDatanodeDatabase { + + private static Map<String, String> queries; + + static { + loadProperties(); + } + + private static void loadProperties() { + Properties props = new Properties(); + try (InputStream inputStream = ContainerDatanodeDatabase.class.getClassLoader() + .getResourceAsStream(DBConsts.PROPS_FILE)) { + + if (inputStream != null) { + props.load(inputStream); + queries = props.entrySet().stream() + .collect(Collectors.toMap( + e -> e.getKey().toString(), + e -> e.getValue().toString() + )); + } else { + throw new FileNotFoundException("Property file '" + DBConsts.PROPS_FILE + "' not found."); + } + } catch (Exception e) { + e.printStackTrace(); + } + } + + private static Connection getConnection() throws Exception { + Class.forName(DBConsts.DRIVER); + + SQLiteConfig config = new SQLiteConfig(); + + config.setJournalMode(SQLiteConfig.JournalMode.OFF); + config.setCacheSize(DBConsts.CACHE_SIZE); + config.setLockingMode(SQLiteConfig.LockingMode.EXCLUSIVE); + config.setSynchronous(SQLiteConfig.SynchronousMode.OFF); + config.setTempStore(SQLiteConfig.TempStore.MEMORY); + + return DriverManager.getConnection(DBConsts.CONNECTION_PREFIX + DBConsts.DATABASE_NAME, config.toProperties()); + } + + public void createDatanodeContainerLogTable() { + String createTableSQL = queries.get("CREATE_DATANODE_CONTAINER_LOG_TABLE"); + try (Connection connection = getConnection(); + Statement dropStmt = connection.createStatement(); + Statement createStmt = connection.createStatement()) { + dropTable(DBConsts.DATANODE_CONTAINER_LOG_TABLE_NAME,dropStmt); + createStmt.execute(createTableSQL); + createDatanodeContainerIndex(createStmt); + } catch (SQLException e) { + System.err.println("Error while creating the table: " + e.getMessage()); + } catch (Exception e) { + throw new RuntimeException(e); + } + } + + private void createContainerLogTable() { + String createTableSQL = queries.get("CREATE_CONTAINER_LOG_TABLE"); + try (Connection connection = getConnection(); + Statement dropStmt = connection.createStatement(); + Statement createStmt = connection.createStatement()) { + dropTable(DBConsts.CONTAINER_LOG_TABLE_NAME,dropStmt); + createStmt.execute(createTableSQL); + } catch (SQLException e) { + System.err.println("Error while creating the table: " + e.getMessage()); + } catch (Exception e) { + throw new RuntimeException(e); + } + } + + public void insertContainerDatanodeData(String key, List<DatanodeContainerInfo> transitionList) { + String[] parts = key.split("#"); + if (parts.length != 2) { + System.err.println("Invalid key format: " + key); + return; + } + + long containerId = Long.parseLong(parts[0]); + long datanodeId = Long.parseLong(parts[1]); + + String insertSQL = queries.get("INSERT_DATANODE_CONTAINER_LOG"); + + try (Connection connection = getConnection(); + PreparedStatement preparedStatement = connection.prepareStatement(insertSQL)) { + + int count = 0; + + for (DatanodeContainerInfo info : transitionList) { + preparedStatement.setLong(1, datanodeId); + preparedStatement.setLong(2, containerId); + preparedStatement.setString(3, info.getTimestamp()); + preparedStatement.setString(4, info.getState()); + preparedStatement.setLong(5, info.getBcsid()); + preparedStatement.setString(6, info.getErrorMessage()); + preparedStatement.addBatch(); + + count++; + + if (count % DBConsts.BATCH_SIZE == 0) { + preparedStatement.executeBatch(); + count = 0; + } + } + + if (count != 0) { + preparedStatement.executeBatch(); + } + } catch (SQLException e) { + System.err.println("Error while inserting data: " + e.getMessage()); + for (DatanodeContainerInfo info : transitionList) { + System.err.println("Attempting to insert - datanode_id: " + datanodeId + ", container_id: " + containerId + Review Comment: may need throw exception here also. ########## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/containerlog/parser/ContainerDatanodeDatabase.java: ########## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.containerlog.parser; + +import java.io.FileNotFoundException; +import java.io.InputStream; +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.List; +import java.util.Map; +import java.util.Properties; +import java.util.stream.Collectors; +import org.sqlite.SQLiteConfig; + +/** + * Datanode container Database. + */ + +public class ContainerDatanodeDatabase { + + private static Map<String, String> queries; + + static { + loadProperties(); + } + + private static void loadProperties() { + Properties props = new Properties(); + try (InputStream inputStream = ContainerDatanodeDatabase.class.getClassLoader() + .getResourceAsStream(DBConsts.PROPS_FILE)) { + + if (inputStream != null) { + props.load(inputStream); + queries = props.entrySet().stream() + .collect(Collectors.toMap( + e -> e.getKey().toString(), + e -> e.getValue().toString() + )); + } else { + throw new FileNotFoundException("Property file '" + DBConsts.PROPS_FILE + "' not found."); + } + } catch (Exception e) { + e.printStackTrace(); + } + } + + private static Connection getConnection() throws Exception { + Class.forName(DBConsts.DRIVER); + + SQLiteConfig config = new SQLiteConfig(); + + config.setJournalMode(SQLiteConfig.JournalMode.OFF); + config.setCacheSize(DBConsts.CACHE_SIZE); + config.setLockingMode(SQLiteConfig.LockingMode.EXCLUSIVE); + config.setSynchronous(SQLiteConfig.SynchronousMode.OFF); + config.setTempStore(SQLiteConfig.TempStore.MEMORY); + + return DriverManager.getConnection(DBConsts.CONNECTION_PREFIX + DBConsts.DATABASE_NAME, config.toProperties()); + } + + public void createDatanodeContainerLogTable() { + String createTableSQL = queries.get("CREATE_DATANODE_CONTAINER_LOG_TABLE"); + try (Connection connection = getConnection(); + Statement dropStmt = connection.createStatement(); + Statement createStmt = connection.createStatement()) { + dropTable(DBConsts.DATANODE_CONTAINER_LOG_TABLE_NAME,dropStmt); + createStmt.execute(createTableSQL); + createDatanodeContainerIndex(createStmt); + } catch (SQLException e) { + System.err.println("Error while creating the table: " + e.getMessage()); + } catch (Exception e) { + throw new RuntimeException(e); + } + } + + private void createContainerLogTable() { + String createTableSQL = queries.get("CREATE_CONTAINER_LOG_TABLE"); + try (Connection connection = getConnection(); + Statement dropStmt = connection.createStatement(); + Statement createStmt = connection.createStatement()) { + dropTable(DBConsts.CONTAINER_LOG_TABLE_NAME,dropStmt); + createStmt.execute(createTableSQL); + } catch (SQLException e) { + System.err.println("Error while creating the table: " + e.getMessage()); + } catch (Exception e) { + throw new RuntimeException(e); + } + } + + public void insertContainerDatanodeData(String key, List<DatanodeContainerInfo> transitionList) { + String[] parts = key.split("#"); + if (parts.length != 2) { + System.err.println("Invalid key format: " + key); + return; + } + + long containerId = Long.parseLong(parts[0]); + long datanodeId = Long.parseLong(parts[1]); + + String insertSQL = queries.get("INSERT_DATANODE_CONTAINER_LOG"); + + try (Connection connection = getConnection(); + PreparedStatement preparedStatement = connection.prepareStatement(insertSQL)) { Review Comment: may be preparedStatement also needs to be released. ########## hadoop-ozone/tools/src/main/resources/container-log-db-queries.properties: ########## @@ -0,0 +1,24 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +CREATE_DATANODE_CONTAINER_LOG_TABLE=CREATE TABLE IF NOT EXISTS DatanodeContainerLogTable (datanode_id INTEGER NOT NULL, container_id INTEGER NOT NULL, timestamp TEXT NOT NULL, container_state TEXT NOT NULL, bcsid INTEGER NOT NULL, error_message TEXT, PRIMARY KEY (datanode_id, container_id, container_state, bcsid, error_message)); +CREATE_CONTAINER_LOG_TABLE=CREATE TABLE IF NOT EXISTS ContainerLogTable (datanode_id INTEGER NOT NULL, container_id INTEGER NOT NULL, latest_state TEXT NOT NULL, latest_bcsid INTEGER NOT NULL, PRIMARY KEY (datanode_id, container_id)); +CREATE_DATANODE_CONTAINER_INDEX=CREATE INDEX IF NOT EXISTS idx_datanode_container ON DatanodeContainerLogTable (datanode_id, container_id); +INSERT_DATANODE_CONTAINER_LOG=INSERT OR REPLACE INTO DatanodeContainerLogTable (datanode_id, container_id, timestamp, container_state, bcsid, error_message) VALUES (?, ?, ?, ?, ?, ?); +INSERT_CONTAINER_LOG=INSERT OR REPLACE INTO ContainerLogTable (datanode_id, container_id, latest_state, latest_bcsid) VALUES (?, ?, ?, ?); Review Comment: do we really need this table? this can be obtained from master table itself. ########## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/containerlog/parser/ContainerDatanodeDatabase.java: ########## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.containerlog.parser; + +import java.io.FileNotFoundException; +import java.io.InputStream; +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.List; +import java.util.Map; +import java.util.Properties; +import java.util.stream.Collectors; +import org.sqlite.SQLiteConfig; + +/** + * Datanode container Database. + */ + +public class ContainerDatanodeDatabase { + + private static Map<String, String> queries; + + static { + loadProperties(); + } + + private static void loadProperties() { + Properties props = new Properties(); + try (InputStream inputStream = ContainerDatanodeDatabase.class.getClassLoader() + .getResourceAsStream(DBConsts.PROPS_FILE)) { + + if (inputStream != null) { + props.load(inputStream); + queries = props.entrySet().stream() + .collect(Collectors.toMap( + e -> e.getKey().toString(), + e -> e.getValue().toString() + )); + } else { + throw new FileNotFoundException("Property file '" + DBConsts.PROPS_FILE + "' not found."); + } + } catch (Exception e) { + e.printStackTrace(); + } + } + + private static Connection getConnection() throws Exception { + Class.forName(DBConsts.DRIVER); + + SQLiteConfig config = new SQLiteConfig(); + + config.setJournalMode(SQLiteConfig.JournalMode.OFF); + config.setCacheSize(DBConsts.CACHE_SIZE); + config.setLockingMode(SQLiteConfig.LockingMode.EXCLUSIVE); + config.setSynchronous(SQLiteConfig.SynchronousMode.OFF); + config.setTempStore(SQLiteConfig.TempStore.MEMORY); + + return DriverManager.getConnection(DBConsts.CONNECTION_PREFIX + DBConsts.DATABASE_NAME, config.toProperties()); + } + + public void createDatanodeContainerLogTable() { + String createTableSQL = queries.get("CREATE_DATANODE_CONTAINER_LOG_TABLE"); + try (Connection connection = getConnection(); + Statement dropStmt = connection.createStatement(); + Statement createStmt = connection.createStatement()) { + dropTable(DBConsts.DATANODE_CONTAINER_LOG_TABLE_NAME,dropStmt); + createStmt.execute(createTableSQL); + createDatanodeContainerIndex(createStmt); + } catch (SQLException e) { + System.err.println("Error while creating the table: " + e.getMessage()); + } catch (Exception e) { + throw new RuntimeException(e); + } + } + + private void createContainerLogTable() { + String createTableSQL = queries.get("CREATE_CONTAINER_LOG_TABLE"); + try (Connection connection = getConnection(); + Statement dropStmt = connection.createStatement(); + Statement createStmt = connection.createStatement()) { + dropTable(DBConsts.CONTAINER_LOG_TABLE_NAME,dropStmt); + createStmt.execute(createTableSQL); + } catch (SQLException e) { + System.err.println("Error while creating the table: " + e.getMessage()); + } catch (Exception e) { + throw new RuntimeException(e); + } + } + + public void insertContainerDatanodeData(String key, List<DatanodeContainerInfo> transitionList) { + String[] parts = key.split("#"); + if (parts.length != 2) { + System.err.println("Invalid key format: " + key); + return; + } + + long containerId = Long.parseLong(parts[0]); + long datanodeId = Long.parseLong(parts[1]); + + String insertSQL = queries.get("INSERT_DATANODE_CONTAINER_LOG"); + + try (Connection connection = getConnection(); + PreparedStatement preparedStatement = connection.prepareStatement(insertSQL)) { + + int count = 0; + + for (DatanodeContainerInfo info : transitionList) { + preparedStatement.setLong(1, datanodeId); + preparedStatement.setLong(2, containerId); + preparedStatement.setString(3, info.getTimestamp()); + preparedStatement.setString(4, info.getState()); + preparedStatement.setLong(5, info.getBcsid()); + preparedStatement.setString(6, info.getErrorMessage()); + preparedStatement.addBatch(); + + count++; + + if (count % DBConsts.BATCH_SIZE == 0) { + preparedStatement.executeBatch(); + count = 0; + } + } + + if (count != 0) { + preparedStatement.executeBatch(); + } + } catch (SQLException e) { + System.err.println("Error while inserting data: " + e.getMessage()); + for (DatanodeContainerInfo info : transitionList) { + System.err.println("Attempting to insert - datanode_id: " + datanodeId + ", container_id: " + containerId + + ", timestamp: " + info.getTimestamp() + ", container_state: " + info.getState() + + ", bcsid: " + info.getBcsid() + ", error_message: " + info.getErrorMessage()); + } + } catch (Exception e) { + throw new RuntimeException(e); Review Comment: can have log on each failure or at caller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
