sadanand48 commented on code in PR #8186:
URL: https://github.com/apache/ozone/pull/8186#discussion_r2019718433
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointServlet.java:
##########
@@ -229,9 +232,10 @@ private void generateSnapshotCheckpoint(HttpServletRequest
request,
long duration = Duration.between(start, end).toMillis();
LOG.info("Time taken to write the checkpoint to response output " +
"stream: {} milliseconds", duration);
-
- LOG.info("Excluded SST {} from the latest checkpoint.",
- excludedSstList);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Excluded SST {} from the latest checkpoint. The total
excluded sst files count is {}",
+ excludedSstList.subList(0, Math.min(5, excludedSstList.size())),
excludedSstList.size());
+ }
Review Comment:
```suggestion
LOG.info("Excluded SST {} from the latest checkpoint. The total
excluded sst files count is {}",
excludedSstList.subList(0, Math.min(5, excludedSstList.size())),
excludedSstList.size());
if (LOG.isDebugEnabled()) {
LOG.debug("Excluded SST {} from the latest checkpoint.",
excludedSstList);
}
```
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointServlet.java:
##########
@@ -195,7 +195,10 @@ private void generateSnapshotCheckpoint(HttpServletRequest
request,
.filter(s -> s.endsWith(ROCKSDB_SST_SUFFIX))
.distinct()
.collect(Collectors.toList()));
- LOG.info("Received excluding SST {}", receivedSstList);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Received excluding SST {}. The total excluded sst files
count is {}",
+ receivedSstList.subList(0, Math.min(5, receivedSstList.size())),
receivedSstList.size());
+ }
Review Comment:
```suggestion
LOG.info("Received excluding SST {}. The total received excluded sst
files count is {}",
receivedSstList.subList(0, Math.min(5, receivedSstList.size())),
receivedSstList.size());
if (LOG.isDebugEnabled()) {
LOG.debug("Received excluding SST {}", receivedSstList);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
