ChenSammi commented on code in PR #8150:
URL: https://github.com/apache/ozone/pull/8150#discussion_r2013614904
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -299,7 +298,6 @@ public DiskBalancerReportProto getDiskBalancerReportProto()
{
DiskBalancerReportProto.Builder builder =
DiskBalancerReportProto.newBuilder();
return builder.setIsRunning(shouldRun)
- .setBalancedBytes(totalBalancedBytes.get())
Review Comment:
Keep this one.
@Gargi-jais11 , please check whether both getDiskBalancerReportProto() and
getDiskBalancerInfo() are needed to report to SCM. It looks like some
duplication here. If we can consolidate getDiskBalancerReportProto and
getDiskBalancerInfo into one, that will make the code clean and more
understandable. If the consolidation is feasible, you can open a new JIRA to
do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
