kerneltime commented on code in PR #8050:
URL: https://github.com/apache/ozone/pull/8050#discussion_r2008014275


##########
hadoop-ozone/dist/src/main/smoketest/admincli/container.robot:
##########
@@ -87,17 +97,54 @@ Report containers as JSON
 List all containers
     ${output} =         Execute          ozone admin container list --all
                         Should contain   ${output}   OPEN
+                        Should Start With   ${output}   [
+                        Should End With   ${output}   ]
 
 List all containers according to count (batchSize)
     ${output} =         Execute          ozone admin container list --all 
--count 10
                         Should contain   ${output}   OPEN
+                        Should Start With   ${output}   [
+                        Should End With   ${output}   ]
 
 List all containers from a particular container ID
-    ${output} =         Execute          ozone admin container list --all 
--start 1
+    ${output} =         Execute          ozone admin container list --all 
--start 2
                         Should contain   ${output}   OPEN
+                        Should Start With   ${output}   [
+                        Should End With   ${output}   ]
+
+Check JSON array parsing
+    ${output} =         Execute          ozone admin container list
+                        Should Start With   ${output}   [
+                        Should Contain   ${output}   containerID
+                        Should End With   ${output}   ]
+    ${containerIDs} =   Execute          echo '${output}' | jq -r 
'.[].containerID'
+                        Should Not Be Empty   ${containerIDs}
+
+Check state filtering with JSON array format
+    ${output} =         Execute          ozone admin container list 
--state=OPEN
+                        Should Start With   ${output}   [
+                        Should End With   ${output}   ]
+    ${states} =         Execute          echo '${output}' | jq -r '.[].state'
+                        Should Contain   ${states}   OPEN
+                        Should Not Contain   ${states}   CLOSED
+
+Check count limit with JSON array format
+    ${output} =         Execute          ozone admin container create
+                        Should contain   ${output}   is created
+    ${output} =         Execute          ozone admin container create
+                        Should contain   ${output}   is created
+    ${output} =         Execute          ozone admin container create
+                        Should contain   ${output}   is created
+    ${output} =         Execute          ozone admin container create
+                        Should contain   ${output}   is created
+    ${output} =         Execute          ozone admin container create
+                        Should contain   ${output}   is created

Review Comment:
   Yes the robot tests need an over haul



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to