Tejaskriya commented on code in PR #7957:
URL: https://github.com/apache/ozone/pull/7957#discussion_r2004965828


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OMAdminProtocolServerSideImpl.java:
##########
@@ -101,4 +103,22 @@ public DecommissionOMResponse decommission(RpcController 
controller,
         .setSuccess(true)
         .build();
   }
+
+  @Override
+  public CompactResponse compactDB(RpcController controller, CompactRequest 
compactRequest)
+      throws ServiceException {
+    try {
+      // check if table exists. IOException is thrown if table is not found.

Review Comment:
   Currently we are doing the check in `OzoneManager` by checking the user 
priviledge. This is the output for when the user doesn't have permissions:
   ```
   bash-4.2$ ozone repair om compact --cf=fileTable --service-id=omservice 
--node-id=om2
   ATTENTION: Running as user hadoop. Make sure this is the same user used to 
run the Ozone process. Are you sure you want to continue (y/N)? y
   Run as user: hadoop
   Couldn't compact column fileTable. 
   Exception: java.io.IOException: Request Failed. Error: Request to compact 
'fileTable', sent to om2[om2:9862] failed with error: Only Ozone admins are 
allowed to compact column family fileTable
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to