devmadhuu commented on code in PR #8002:
URL: https://github.com/apache/ozone/pull/8002#discussion_r1986934122
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconControllerModule.java:
##########
@@ -131,7 +130,6 @@ static class ReconOmTaskBindingModule extends
AbstractModule {
protected void configure() {
Multibinder<ReconOmTask> taskBinder =
Multibinder.newSetBinder(binder(), ReconOmTask.class);
- taskBinder.addBinding().to(ContainerKeyMapperTask.class);
Review Comment:
You removed, but don't see adding the new ones "`ContainerKeyMapperTaskFSO`"
and "`ContainerKeyMapperTaskOBS`". This means integration testing not done.
1. Please also check the upgrade impact and also check because of #7960 ,
will it force re-process of both ContainerKeyMapper tasks ? Can we avoid them ?
2. Pls check the same for FileSizeCount task.
3. Can you pls check the value of all fields of ReconTaskStatus for existing
ConatinerKeyMapper task record in table post upgrade as well as hadoop metrics
values ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
