myskov commented on code in PR #8080: URL: https://github.com/apache/ozone/pull/8080#discussion_r1995098428
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManagerUtil.java: ########## @@ -78,7 +78,7 @@ public static List<DatanodeDetails> getTargetDatanodes(PlacementPolicy policy, // Ensure that target datanodes have enough space to hold a complete // container. final long dataSizeRequired = - Math.max(container.getUsedBytes(), defaultContainerSize); + Math.max(container.getUsedBytes(), defaultContainerSize * 2); Review Comment: What if datanode's behaviour will change to 'containerSize * 3'? Let's extract this check to a separate class and use it on both sides (SCM and datanode). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org