Tejaskriya commented on PR #8016: URL: https://github.com/apache/ozone/pull/8016#issuecomment-2717105382
@hemantk-12 The util class I had added `PopulateCompactionTable` was for the backward compatibility point you have mentioned above, all the methods in that class are for parsing the log file and adding it to the rocksDB compactionLogTable. It doesn't deal with the graph creation aspect of the command. For the methods to add/remove input/output file nodes, I have created the methods in `CompactionLogDagPrinter` itself. It can be moved to `PrintableGraph` but the patch size might increase even more as it will need refactoring in `RocksDBCheckpointDiffer, PrintableGraph, CompactionLogDagPrinter`. I suggest to have a follow-up jira which refactors the graph related method. Would that be okay? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
