ChenSammi commented on code in PR #8056:
URL: https://github.com/apache/ozone/pull/8056#discussion_r1990899169


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -505,7 +507,50 @@ private void postCall() {
 
   public DiskBalancerInfo getDiskBalancerInfo() {
     return new DiskBalancerInfo(shouldRun, threshold, bandwidthInMB,
-        parallelThread, version, metrics.getSuccessCount(), 
metrics.getFailureCount());
+        parallelThread, version, metrics.getSuccessCount(),
+        metrics.getFailureCount(), estimatedTotalSizePendingToMove());
+  }
+
+  private long estimatedTotalSizePendingToMove() {

Review Comment:
   1. estimatedTotalSizePendingToMove -> calculateBytesToMove()
   2. call calculateBytesToMove from getTasks()
   3. add a gobal long field bytesToMove for DiskBalancerService.java to save 
the result of calculateBytesToMove
   4. please add unit tests for this function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to