peterxcli commented on code in PR #7951:
URL: https://github.com/apache/ozone/pull/7951#discussion_r1989127584
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SCMSafeModeManager.java:
##########
@@ -317,30 +318,29 @@ public static Logger getLogger() {
return LOG;
}
- @VisibleForTesting
Review Comment:
I remember @adoroszlai said that `@VisibleForTesting` should not be added to
getters because it doesn't cause any harm if called. However, these three
unrelated changes shouldn't be made, so I would revert them. Thanks for
pointing this out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
