swamirishi commented on code in PR #8022:
URL: https://github.com/apache/ozone/pull/8022#discussion_r1986122458
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java:
##########
@@ -528,6 +557,15 @@ private ContainerCommandResponseProto dispatchCommand(
private CompletableFuture<Message> writeStateMachineData(
ContainerCommandRequestProto requestProto, long entryIndex, long term,
long startTime) {
+ if (writeChunkFutureMap.containsKey(entryIndex)) {
+ // generally state machine will wait forever, for precaution, a check is
added if retry happens.
+ return writeChunkFutureMap.get(entryIndex).getRaftFuture();
+ }
+ try {
+ validateLongRunningWrite(entryIndex);
+ } catch (IOException e) {
Review Comment:
Do we want to have another exception handling here? Even if this gets
submitted to the threadpool it will fail since we have marked the statemachine
as unhealthy. Do we want this optmization to fail fast here? Eventually the
pipeline will close anyhow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
