xichen01 commented on code in PR #8008:
URL: https://github.com/apache/ozone/pull/8008#discussion_r1981714618
##########
hadoop-ozone/ozonefs-shaded/pom.xml:
##########
@@ -102,6 +102,21 @@
<phase>package</phase>
<configuration>
<skip>${maven.shade.skip}</skip>
+ <artifactSet>
+ <excludes>
+ <!-- Leave snappy that includes native methods which cannot
be relocated. -->
+ <exclude>org.xerial.snappy:*</exclude>
Review Comment:
Yes, I refer to this
https://github.com/viirya/hadoop/blob/7eb09762f38ac825d8614f6ecc42d041efd087bf/hadoop-client-modules/hadoop-client-api/pom.xml#L120
it said the `org.xerial.snappy` (JNI method ) should not be shaded and
excluded it.
But seem we need add it in dependency, let it as transitive dependency to
make the downstream?
How do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
