errose28 commented on code in PR #7987:
URL: https://github.com/apache/ozone/pull/7987#discussion_r1978365529


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/conf/OzoneConfiguration.java:
##########
@@ -387,7 +387,7 @@ private static void addDeprecatedKeys() {
         new DeprecationDelta("dfs.datanode.hostname",
             HddsConfigKeys.HDDS_DATANODE_HOST_NAME_KEY),
         new DeprecationDelta("dfs.datanode.data.dir",
-            HddsConfigKeys.HDDS_DATANODE_DATA_DIR_KEY),
+            ScmConfigKeys.HDDS_DATANODE_DIR_KEY),

Review Comment:
   I think the current change is all that is required and we don't need a 
deprecation delta for `hdds.datanode.data.dir` because it only existed since 
#7922, but just want to confirm that this is the intended behavior



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to