errose28 commented on code in PR #7957:
URL: https://github.com/apache/ozone/pull/7957#discussion_r1972460618
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/OMRepair.java:
##########
@@ -31,7 +32,8 @@
FSORepairTool.class,
SnapshotRepair.class,
TransactionInfoRepair.class,
- QuotaRepair.class
+ QuotaRepair.class,
+ RocksDBManualCompaction.class
Review Comment:
The commands you referenced were correctly moved from `ozone repair ldb` to
`ozone repair om` because they do not work on all RocksDB instances, they only
work on the OM. Commands under `ozone repair ldb` must be component agnostic
for best usability. This is explained in the tools CLI proposal in #7597
> Commands from different categories should not exist under the same `ozone
debug` subcommand. For example, `ozone debug ldb` should not have a mix of
subcommands that work on all DB instances and some that only work on OM.
After doing this, there were no subcommands under `ozone repair ldb` at the
time so it was removed as well. Now that we have at least one subcommand we can
add it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
