errose28 commented on code in PR #7930:
URL: https://github.com/apache/ozone/pull/7930#discussion_r1964184753


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -73,6 +73,9 @@ public class DatanodeConfiguration extends 
ReconfigurableConfig {
       "hdds.datanode.wait.on.all.followers";
   public static final String CONTAINER_SCHEMA_V3_ENABLED =
       "hdds.datanode.container.schema.v3.enabled";
+  public static final String CONTAINER_SCHEMA_V4_ENABLED =
+      "hdds.datanode.container.schema.v4.enabled";
+  public static final boolean CONTAINER_SCHEMA_V4_ENABLED_DEFAULT = true;

Review Comment:
   We had issues with the schema v3 feature flag in the past because if it was 
enabled then disabled, the schema v3 containers would not get loaded. I don't 
think we should have config keys for container schema versions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to