adoroszlai commented on code in PR #7956:
URL: https://github.com/apache/ozone/pull/7956#discussion_r1966830328
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/freon/TestOmBucketReadWriteKeyOps.java:
##########
@@ -278,22 +278,11 @@ private ParameterBuilder setBufferSize(int
bufferSizeParam) {
return this;
}
- private ParameterBuilder setLength(int lengthParam) {
- length = lengthParam;
- return this;
- }
-
private ParameterBuilder setTotalThreadCount(int totalThreadCountParam) {
totalThreadCount = totalThreadCountParam;
return this;
}
- private ParameterBuilder setReadThreadPercentage(
- int readThreadPercentageParam) {
- readThreadPercentage = readThreadPercentageParam;
- return this;
- }
Review Comment:
Same here.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/freon/TestOmBucketReadWriteFileOps.java:
##########
@@ -293,22 +293,11 @@ private ParameterBuilder setBufferSize(int
bufferSizeParam) {
return this;
}
- private ParameterBuilder setLength(int lengthParam) {
- length = lengthParam;
- return this;
- }
-
private ParameterBuilder setTotalThreadCount(int totalThreadCountParam) {
totalThreadCount = totalThreadCountParam;
return this;
}
- private ParameterBuilder setReadThreadPercentage(
- int readThreadPercentageParam) {
- readThreadPercentage = readThreadPercentageParam;
- return this;
- }
Review Comment:
These are no longer unused with #7870: `TestOmBucketReadWriteFileOps` and
`TestOmBucketReadWriteKeyOps` are refactored to use the same `ParameterBuilder`
class (get rid of duplication) and test cases tweaked to exercise each
parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
