peterxcli commented on code in PR #7953:
URL: https://github.com/apache/ozone/pull/7953#discussion_r1966699403
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClient.java:
##########
@@ -36,6 +37,7 @@ public static void init() throws Exception {
OzoneConfiguration conf = new OzoneConfiguration();
conf.setInt(ScmConfigKeys.OZONE_SCM_PIPELINE_OWNER_CONTAINER_COUNT, 1);
conf.setBoolean(OzoneConfigKeys.OZONE_ACL_ENABLED, true);
+ conf.set(OMConfigKeys.OZONE_OM_FEATURES_DISABLED, "ATOMIC_REWRITE_KEY");
Review Comment:
I think this would disable the feature for the whole, maybe we should add
some test cases and set the disabled feature configuration in them.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/OzoneRpcClientTests.java:
##########
@@ -1440,6 +1450,14 @@ private static void
assertMetadataUnchanged(OzoneKeyDetails original, OzoneKeyDe
assertEquals(original.getMetadata(), rewritten.getMetadata());
}
+ private static void checkFeatureEnable() {
Review Comment:
I think we should make the function name clear
```suggestion
private static void checkAtomicKeyRewriteFeatureEnable() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
